Reviews for ChromeLogger
ChromeLogger by BurningMoth
Review by skrymir01
Rated 5 out of 5
by skrymir01, 7 years agoUpdated Review:
Issue's been resolved and logs my messages like a champ.
Previous Review:
Produces error: TypeError: window.console[method] is undefined
The reason appears to be that it assumes the console method will be sent in the response. This will be the case for the all logging types _except_ "log". According to the Chrome Logger technical specifications at https://craig.is/writing/chrome-logger/techspecs, if you want to log, you should send an empty string (to save on size). Therefore the add-on ought to use "log" if "method" is empty. I believe the following would be sufficient to fix it:
console[method || 'log']
I couldn't find a repository to log this issue at or submit a pull request, so I had to use the review section.
Issue's been resolved and logs my messages like a champ.
Previous Review:
Produces error: TypeError: window.console[method] is undefined
The reason appears to be that it assumes the console method will be sent in the response. This will be the case for the all logging types _except_ "log". According to the Chrome Logger technical specifications at https://craig.is/writing/chrome-logger/techspecs, if you want to log, you should send an empty string (to save on size). Therefore the add-on ought to use "log" if "method" is empty. I believe the following would be sufficient to fix it:
console[method || 'log']
I couldn't find a repository to log this issue at or submit a pull request, so I had to use the review section.